Support messenger-lite as meta_platform#71
Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe pull request adds "messenger-lite" as a recognized meta platform variant in the bridge configuration, configuring it to use Facebook bridge settings, while simultaneously marking it as an invalid user-specified platform value in the configuration tool. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmd/bbctl/config.go (1)
74-85: Auto-detection may incorrectly infermessengerinstead ofmessenger-lite.The auto-detection logic at lines 78-79 checks if
bridgeNamecontains "messenger" and setsmetaPlatform = "messenger". Since "messenger-lite" also contains "messenger", a bridge named something likesh-messenger-litewould be auto-detected asmessengerrather thanmessenger-lite.Consider adding an explicit check for "messenger-lite" before the "messenger" check:
Suggested fix
if strings.Contains(bridgeName, "facebook-tor") || strings.Contains(bridgeName, "facebooktor") { metaPlatform = "facebook-tor" } else if strings.Contains(bridgeName, "facebook") { metaPlatform = "facebook" + } else if strings.Contains(bridgeName, "messenger-lite") || strings.Contains(bridgeName, "messengerlite") { + metaPlatform = "messenger-lite" } else if strings.Contains(bridgeName, "messenger") { metaPlatform = "messenger" } else if strings.Contains(bridgeName, "instagram") {
2 participants
This is already supported in the bridge, adding it to the default configuration generator for convenience.